Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test stage with minified Android builds #1190

Merged
merged 8 commits into from
Jan 9, 2023
Merged

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented Dec 21, 2022

This adds a test-sync test stage running all sync tests with minification on Android. It was not possible to add minification for test-base due to our current project setup, but as test-sync holds quite many models and cover reasonably base functionality it will in fact act as a sanity validation of our library-base/proguard-rules-consumer-common.pro configuration, especially initialization of the native class and method references.

If needed it is relatively easy to manually run the full test-base test suite with minification following the instructions in test-base/build.gradle.kts

Closes #1114

@cla-bot cla-bot bot added the cla: yes label Dec 21, 2022
@clementetb
Copy link
Contributor

We could enable running test-base with minification in CI if we remove its dependency from test-sync. We could manually link the shared sources and add the kotlinx-datetime dependency to test-sync.

packages/gradle.properties Outdated Show resolved Hide resolved
packages/test-base/build.gradle.kts Show resolved Hide resolved
Co-authored-by: Christian Melchior <[email protected]>
Copy link
Contributor

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green

@rorbech rorbech merged commit 4c127c1 into releases Jan 9, 2023
@rorbech rorbech deleted the cr/minified-tests branch January 9, 2023 21:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants