Bump core to version 13.23.1 #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
Oct 12, 2023
nhachicha
approved these changes
Oct 12, 2023
clementetb
force-pushed
the
ct/bump-core-13.23.0
branch
from
3db129b to
5098395
Compare
|
We should also fix #1546 as part of this |
|
closes #1546 |
rorbech
reviewed
Oct 17, 2023
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/User.kt
Outdated
Show resolved
Hide resolved
| @@ -391,7 +391,7 @@ class AppTests { | |||
| Realm.open(syncConfig).close() | |||
|
|
|||
| // Create a configuration pointing to the metadata Realm for that app | |||
| val lastSetSchemaVersion = 6L | |||
| val lastSetSchemaVersion = 7L | |||
There was a problem hiding this comment.
Hmm. I don't really know the full consequence of this, but from this comment it seems that we should at least warn about not being able to downgrade 🤔
There was a problem hiding this comment.
We are opening the metadata directly instead of opening a higher schema version with an app to trigger a schema downgrade.
I am going to create a ticket to validate what is the expected behavior when downgrading an App metadata schema.
There was a problem hiding this comment.
Ahh sorry, forgot the link to the comment I was referring to: #1528 (comment)
…ngodb/User.kt Co-authored-by: Claus Rørbech <[email protected]>
cmelchior
approved these changes
Oct 19, 2023
Co-authored-by: Christian Melchior <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps core to version 13.23.0.
Core has removed
realm_user_get_auth_provider, in reaction to this we have annotatedUser.provideras deprecated and now returns the first element auth provider atUser.identities.