Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RKOTLIN-1100] Clean up build system #1770

Merged
merged 31 commits into from
Jun 20, 2024
Merged

[RKOTLIN-1100] Clean up build system #1770

merged 31 commits into from
Jun 20, 2024

Conversation

clementetb
Copy link
Contributor

@clementetb clementetb commented May 30, 2024 •
edited
Loading

This PR removes all the known warnings by addressing or suppressing them, some other changes in this PR:

  • Bumped minimum R8.
  • Ignore temp test files in the project directory.
  • Updated to Detekt.
  • Refactor CoreConnectionState because native method byValuedeprecation.

Closes #1773

@cla-bot cla-bot bot added the cla: yes label May 30, 2024
@clementetb clementetb changed the title Update build scripts and remove warnings [RKOTLIN-1100] Clean up build system Jun 3, 2024
@clementetb clementetb force-pushed the ct/update_build_scripts branch from 453f8a9 to 43c0037 Compare June 4, 2024 10:47
@clementetb clementetb marked this pull request as ready for review June 10, 2024 09:23
@clementetb clementetb requested review from rorbech and nhachicha June 11, 2024 08:19
rorbech
rorbech reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome cleanup - Had some minor questions that might need to be addressed, but not sure 😅

packages/jni-swig-stub/build.gradle.kts Show resolved Hide resolved
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/Converters.kt Outdated Show resolved Hide resolved
packages/settings.gradle.kts Outdated Show resolved Hide resolved
@clementetb clementetb merged commit 71fbef9 into main Jun 20, 2024
67 checks passed
@clementetb clementetb deleted the ct/update_build_scripts branch June 20, 2024 09:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rorbech rorbech rorbech approved these changes

@nhachicha nhachicha Awaiting requested review from nhachicha

Assignees

@clementetb clementetb

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up build system
2 participants
@clementetb @rorbech