Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test app initializer rework #1785

Merged
merged 13 commits into from
Jul 5, 2024
Merged

Test app initializer rework #1785

merged 13 commits into from
Jul 5, 2024

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented Jun 19, 2024

This PR reworks our test app initializer, so that it is easier to do variations of the setup.

@cla-bot cla-bot bot added the cla: yes label Jun 19, 2024
@rorbech rorbech changed the title Add sync test for legacy mixed properties Test app initializer rework Jun 20, 2024
@rorbech rorbech added no-jira-ticket Skip checking the PR title for Jira reference and removed no-changelog labels Jun 26, 2024
@rorbech rorbech requested review from clementetb and nhachicha June 26, 2024 11:53
@rorbech rorbech marked this pull request as ready for review June 26, 2024 11:53
Copy link
Contributor

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome it looks great. The only concern is that I cannot rerun roundtripCollectionsInMixed without resetting the server.

@rorbech
Copy link
Contributor Author

rorbech commented Jun 27, 2024

Awesome it looks great. The only concern is that I cannot rerun roundtripCollectionsInMixed without resetting the server.

Should be fixed now.

@rorbech rorbech merged commit 5e41c65 into main Jul 5, 2024
78 checks passed
@rorbech rorbech deleted the cr/legacy-mixed-test branch July 5, 2024 13:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants