Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GHA workflows to work with the macOS image changes #8713

Draft
wants to merge 4 commits into
base: community
Choose a base branch
from
Draft

Update GHA workflows to work with the macOS image changes #8713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c64cdc
Run pull request tests on Github Actions (#8681)
tgoyne Sep 17, 2024
2603f70
Replace Xcode 16.0 beta 6 with 16.0
tgoyne Sep 18, 2024
e762416
Upgrade to core v20.1.0
tgoyne Sep 21, 2024
4abc81e
Update GHA workflows to work with the macOS image changes
tgoyne Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@ jobs:
strategy:
matrix:
target: [macosx, iphoneos, iphonesimulator, appletvos, appletvsimulator, watchos, watchsimulator, maccatalyst, xros, xrsimulator]
xcode: ["15.3"]
env:
DEVELOPER_DIR: /Applications/Xcode_15.3.app/Contents/Developer
steps:
- uses: actions/checkout@v4

- name: Switch to Xcode ${{ matrix.xcode }}
uses: maxim-lobanov/[email protected]
with:
xcode-version: ${{ matrix.xcode }}
- name: Download visionOS
if: matrix.target == 'xros' || matrix.target == 'xrsimulator'
run: xcodebuild -downloadPlatform visionOS

- name: Get Core Version
id: get-core-version
Expand All @@ -44,6 +43,11 @@ jobs:
fetch-depth: 0
fetch-tags: true

# CMake 3.30 introduced a check which tries to validate that the compiler
# supports the requested architextures but it doesn't work.
- name: Patch CMake
run: sed -i '' 's/CMAKE_HOST_APPLE AND CMAKE_SYSTEM_NAME STREQUAL "Darwin"/CMAKE_HOST_APPLE AND CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND NOT CMAKE_GENERATOR STREQUAL "Xcode"/' /opt/homebrew/Cellar/cmake/*/share/cmake/Modules/CMakeDetermineCompilerABI.cmake

- name: Checkout Core@${{ steps.get-core-version.outputs.version }}
run: git checkout ${{ steps.get-core-version.outputs.version }} --recurse-submodules -f
working-directory: core
Expand Down
Loading
Loading