Don't explicitly set window flags when displaying the scrollback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit calls to setWindowFlags() like the following
this->fScrollbackWindow->setWindowFlags(Qt::Window);
this->fScrollbackWindow->setWindowFlags(Qt::Widget);
yield display corruption when enabling the overlay for the first time on
Qt5/OSX.
These calls are unnecessary as reparenting the scrollback widget implicitly
determines whether a widget should be displayed in a separate/independent
window.
realnc
added a commit
that referenced
this pull request
Apr 20, 2014
Don't explicitly set window flags when displaying the scrollback
|
Thanks :-) |
|
Np! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit calls to
setWindowFlags()like the followingyield display corruption when re-enabling scrollback overlay mode (reproducible: Qt5/OSX).
These calls are unnecessary as reparenting the scrollback widget implicitly determines whether it should be displayed in a separate/independent window.