Skip to content

Commit

Permalink
Tests: Use PHPUnit 9 and test method prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
realodix committed Mar 17, 2024
1 parent de023d0 commit 4d9f4da
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 42 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"require-dev": {
"phpstan/phpstan": "^1.10",
"phpunit/phpunit": "^9.6 || ^10.0"
"phpunit/phpunit": "^9.6"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down
14 changes: 4 additions & 10 deletions tests/Feature/ConfigTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@ class ConfigTest extends TestCase
/**
* The input of rule set is valid
*
* @test
* @dataProvider validRuleSetInputProvider
*/
public function validRuleSetInput($ruleSet): void
public function testValidRuleSetInput($ruleSet): void
{
$this->assertInstanceOf(
\PhpCsFixer\ConfigInterface::class,
Expand All @@ -27,10 +26,9 @@ public function validRuleSetInput($ruleSet): void
/**
* The input of rule set is invalid
*
* @test
* @dataProvider invalidRuleSetInputProvider
*/
public function invalidRuleSetInput($ruleSet, $expectException): void
public function testInvalidRuleSetInput($ruleSet, $expectException): void
{
$this->expectException($expectException);

Expand All @@ -42,10 +40,8 @@ public function invalidRuleSetInput($ruleSet, $expectException): void

/**
* User dapat menambahkan/menonaktifkan rules
*
* @test
*/
public function userCanAddLocalRules(): void
public function testUserCanAddLocalRules(): void
{
$rules1 = Config::create(new RuleSetFile)->getRules();
$rules2 = ['foo' => 'bar'];
Expand All @@ -59,10 +55,8 @@ public function userCanAddLocalRules(): void

/**
* Nama aturan ketika user menambahkan aturan lokal
*
* @test
*/
public function theNameOfTheRuleWhenTheUserAddsALocalRule(): void
public function testTheNameOfTheRuleWhenTheUserAddsALocalRule(): void
{
$this->assertSame(
'@RuleSetFile (1 rules)',
Expand Down
8 changes: 2 additions & 6 deletions tests/Unit/FinderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ class FinderTest extends TestCase
{
/**
* It returns a PHP CS Fixer finder object
*
* @test
*/
public function baseFinderMustReturnsAPhpCsFinderObject(): void
public function testBaseFinderMustReturnsAPhpCsFinderObject(): void
{
$finder = Finder::base(__DIR__);

Expand All @@ -22,10 +20,8 @@ public function baseFinderMustReturnsAPhpCsFinderObject(): void

/**
* It returns a PHP CS Fixer finder object
*
* @test
*/
public function laravelFinderMustReturnsAPhpCsFinderObject(): void
public function testLaravelFinderMustReturnsAPhpCsFinderObject(): void
{
$finder = Finder::laravel(__DIR__.'/../..');

Expand Down
20 changes: 5 additions & 15 deletions tests/Unit/RuleSetTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ protected function getClassShortName($ruleSet): string

/**
* It implements only interface methods
*
* @test
*/
public function itImplementsOnlyInterfaceMethods(): void
public function testItImplementsOnlyInterfaceMethods(): void
{
$reflect = new \ReflectionClass(new RuleSetFile);
$this->assertCount(1, $reflect->getMethods(\ReflectionMethod::IS_PROTECTED));
Expand All @@ -28,10 +26,8 @@ public function itImplementsOnlyInterfaceMethods(): void

/**
* Nama yang dikembalikan haruslah string yang diimput itu sendiri.
*
* @test
*/
public function ruleSetNameWithStringInput(): void
public function testRuleSetNameWithStringInput(): void
{
$actual = Config::create('@Realodix')->getName();

Expand All @@ -40,10 +36,8 @@ public function ruleSetNameWithStringInput(): void

/**
* Nama yang dikembalikan haruslah nama kelas itu sendiri dengan awalan `@`.
*
* @test
*/
public function ruleSetName(): void
public function testRuleSetName(): void
{
$expected = '@'.$this->getClassShortName(new RuleSetFile);
$actual = (new RuleSetFile)->getName();
Expand All @@ -54,10 +48,8 @@ public function ruleSetName(): void
/**
* Nama yang dikembalikan haruslah nama yang telah ditetapkan di dalam kelas
* tersebut.
*
* @test
*/
public function ruleSetNameWithoutSetName(): void
public function testRuleSetNameWithoutSetName(): void
{
$expected = (new RuleSetWithSetNameFile)->name;
$actual = (new RuleSetWithSetNameFile)->getName();
Expand All @@ -67,10 +59,8 @@ public function ruleSetNameWithoutSetName(): void

/**
* Nama yang dikembalikan haruslah nama yang telah ditetapkan oleh Relax.
*
* @test
*/
public function nameReturnedByLocalRule(): void
public function testNameReturnedByLocalRule(): void
{
$actual = Config::create([])->getName();

Expand Down
6 changes: 2 additions & 4 deletions tests/Unit/UtilsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@
class UtilsTest extends TestCase
{
/**
* @test
* @dataProvider pcsfRuleSetClassExistsProvider
*/
public function pcsfRuleSetClassExists($ruleSetName): void
public function testPcsfRuleSetClassExists($ruleSetName): void
{
$class = Utils::pcsfRuleSetClass($ruleSetName);

Expand All @@ -31,10 +30,9 @@ public static function pcsfRuleSetClassExistsProvider()
}

/**
* @test
* @dataProvider pcsfRuleSetNameToClassNameProvider
*/
public function pcsfRuleSetNameToClassName($actual, $expected): void
public function testPcsfRuleSetNameToClassName($actual, $expected): void
{
$className = Utils::pcsfRuleSetNameToClassName($actual);

Expand Down
8 changes: 2 additions & 6 deletions tests/Unit/ValidRulesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@ class ValidRulesTest extends TestCase
{
/**
* @Realodix set returns a valid PhpCsFIxer rules.
*
* @test
*/
public function realodixReturnsAValidPhpCsFIxerRules(): void
public function testRealodixReturnsAValidPhpCsFIxerRules(): void
{
$rules = $this->getCleanedRules(new \Realodix\Relax\RuleSet\Sets\Realodix);
$factory = (new FixerFactory)
Expand All @@ -26,10 +24,8 @@ public function realodixReturnsAValidPhpCsFIxerRules(): void

/**
* @RealodixPlus set returns a valid PhpCsFIxer rules.
*
* @test
*/
public function realodixPlusReturnsAValidPhpCsFIxerRules(): void
public function testRealodixPlusReturnsAValidPhpCsFIxerRules(): void
{
$rules = $this->getCleanedRules(new \Realodix\Relax\RuleSet\Sets\RealodixPlus);
$factory = (new FixerFactory)
Expand Down

0 comments on commit 4d9f4da

Please sign in to comment.