quota: avoid accessing disk when updating user disk quotas #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 74.32% 74.24% -0.09%
==========================================
Files 7 7
Lines 892 893 +1
==========================================
Hits 663 663
- Misses 229 230 +1
|
tiborsimko
approved these changes
Sep 4, 2023
reana_db/utils.py
Outdated
| @@ -299,6 +299,9 @@ def update_users_disk_quota( | |||
| ) -> None: | |||
| """Update users disk quota usage. | |||
|
|
|||
| User disk quotas will be calculated from workflow disk quotas, | |||
| so the latter should be updated before the former. | |||
There was a problem hiding this comment.
Cosmetics: perhaps add the explicit function name for clarity, e.g. "User disk quota usage will be calculated from the individual workflow disk quota usage numbers, so this function should be typically called only after update_workflows_disk_quota()."
There was a problem hiding this comment.
Please also write an entry into CHANGES.rst about performance improvements for disk quota calculations. (The last PR also omitted news item about this.)
Partially addresses reanahub#193
mdonadoni
force-pushed
the
quota-updater-perf-2
branch
from
64e23a4
to
89c3e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #193