Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support valid min, max, step and value types for various input types #442

Closed
wants to merge 9 commits into from
Closed

Support valid min, max, step and value types for various input types #442

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9193dbb
Support valid min, max, step and value types for various input types
sgny Jun 10, 2019
e896aaf
Use type-safe 'union type' trick
yawaramin Apr 28, 2020
8182a35
Merge pull request #1 from yawaramin/input
sgny Apr 28, 2020
4156328
Merge branch 'master' into input
sgny Apr 29, 2020
3fc8121
handle input step
sgny Apr 29, 2020
c42b627
handle any as step
sgny Apr 29, 2020
6704b65
flatten the Input module
sgny Apr 29, 2020
2024ad0
handle type
sgny May 1, 2020
c75ac38
[ReactDOMRe] simplify Input module and domProps
sgny May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 54 additions & 6 deletions src/ReactDOMRe.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,13 @@ type domProps = {
[@bs.optional]
manifest: string, /* uri */
[@bs.optional]
max: string, /* should be int or Js.Date.t */
max: string,
[@bs.optional] [@bs.as "max"]
maxDate: Js.Date.t,
[@bs.optional] [@bs.as "max"]
maxFloat: float,
[@bs.optional] [@bs.as "max"]
maxInt: int,
[@bs.optional]
maxLength: int,
[@bs.optional]
Expand All @@ -353,7 +359,13 @@ type domProps = {
[@bs.optional]
method: string, /* "post" or "get" */
[@bs.optional]
min: int,
min: string,
[@bs.optional] [@bs.as "min"]
minDate: Js.Date.t,
[@bs.optional] [@bs.as "min"]
minFloat: float,
[@bs.optional] [@bs.as "min"]
minInt: int,
[@bs.optional]
minLength: int,
[@bs.optional]
Expand Down Expand Up @@ -422,7 +434,13 @@ type domProps = {
[@bs.optional]
start: int,
[@bs.optional]
step: float,
step: string,
[@bs.optional] [@bs.as "step"]
stepInt: int,
[@bs.optional] [@bs.as "step"]
stepFloat: float,
[@bs.optional] [@bs.as "step"]
stepDate: float,
[@bs.optional]
summary: string, /* deprecated */
[@bs.optional]
Expand All @@ -433,6 +451,12 @@ type domProps = {
useMap: string,
[@bs.optional]
value: string,
[@bs.optional] [@bs.as "value"]
valueInt: int,
[@bs.optional] [@bs.as "value"]
valueFloat: float,
[@bs.optional] [@bs.as "value"]
valueDate: Js.Date.t,
[@bs.optional]
width: string, /* in html5 this can only be a number, but in html4 it can ba a percentage as well */
[@bs.optional]
Expand Down Expand Up @@ -1346,7 +1370,13 @@ type props = {
[@bs.optional]
manifest: string, /* uri */
[@bs.optional]
max: string, /* should be int or Js.Date.t */
max: string,
[@bs.optional] [@bs.as "max"]
maxDate: Js.Date.t,
[@bs.optional] [@bs.as "max"]
maxFloat: float,
[@bs.optional] [@bs.as "max"]
maxInt: int,
[@bs.optional]
maxLength: int,
[@bs.optional]
Expand All @@ -1356,7 +1386,13 @@ type props = {
[@bs.optional]
method: string, /* "post" or "get" */
[@bs.optional]
min: int,
min: string,
[@bs.optional] [@bs.as "min"]
minDate: Js.Date.t,
[@bs.optional] [@bs.as "min"]
minFloat: float,
[@bs.optional] [@bs.as "min"]
minInt: int,
[@bs.optional]
minLength: int,
[@bs.optional]
Expand Down Expand Up @@ -1425,7 +1461,13 @@ type props = {
[@bs.optional]
start: int,
[@bs.optional]
step: float,
step: string,
[@bs.optional] [@bs.as "step"]
stepInt: int,
[@bs.optional] [@bs.as "step"]
stepFloat: float,
[@bs.optional] [@bs.as "step"]
stepDate: float,
[@bs.optional]
summary: string, /* deprecated */
[@bs.optional]
Expand All @@ -1436,6 +1478,12 @@ type props = {
useMap: string,
[@bs.optional]
value: string,
[@bs.optional] [@bs.as "value"]
valueInt: int,
[@bs.optional] [@bs.as "value"]
valueFloat: float,
[@bs.optional] [@bs.as "value"]
valueDate: Js.Date.t,
[@bs.optional]
width: string, /* in html5 this can only be a number, but in html4 it can ba a percentage as well */
[@bs.optional]
Expand Down