Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateInput component #209

Merged
merged 11 commits into from
May 24, 2024
Merged

DateInput component #209

merged 11 commits into from
May 24, 2024

Conversation

evgenoid
Copy link
Contributor

@evgenoid evgenoid commented May 22, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #192

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screenshot 2024-05-24 at 14 59 29 Screenshot 2024-05-24 at 14 59 35 Screenshot 2024-05-24 at 15 27 08 Screenshot 2024-05-24 at 14 59 45 Screenshot 2024-05-24 at 15 00 12

@evgenoid evgenoid self-assigned this May 22, 2024
@evgenoid evgenoid marked this pull request as draft May 22, 2024 13:42
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 8a0437a
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66508ada91df410008b988b3
😎 Deploy Preview https://deploy-preview-209--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amcdnl
amcdnl reviewed May 22, 2024
View reviewed changes
src/form/Input/InputTheme.ts
@@ -24,7 +24,7 @@ const baseTheme: InputTheme = {
input:
'flex-1 font-normal font-sans bg-transparent border-0 p-0 m-0 disabled:pointer-events-none outline-none px-0.5 disabled:cursor-not-allowed disabled:text-disabled',
inline: 'bg-transparent border-0 outline-none',
disabled: '',
disabled: 'text-waterloo',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be text-disabled ?

@evgenoid evgenoid marked this pull request as ready for review May 24, 2024 11:56
@amcdnl amcdnl merged commit fe729df into master May 24, 2024
5 checks passed
@amcdnl amcdnl deleted the date_input branch May 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcdnl amcdnl amcdnl approved these changes

Assignees

@evgenoid evgenoid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgenoid @amcdnl