Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header):Add header component and cleanup #45

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

nickhowell6425
Copy link
Contributor

  • Add optional header component with flexible content sections

  • Move logo to dedicated assets directory for better organization

  • Fix types import warning for better type safety

  • Add Storybook documentation and examples

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Added a new optional Header component to the chat companion.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

- Add optional header component with flexible content sections

- Move logo to dedicated assets directory for better organization

- Fix types import warning for better type safety

- Add Storybook documentation and examples
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for reachat-storybook ready!

Name Link
🔨 Latest commit dbc4e6c
🔍 Latest deploy log https://app.netlify.com/sites/reachat-storybook/deploys/67af9cfb51058700084b72f8
😎 Deploy Preview https://deploy-preview-45--reachat-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Header/Header.tsx Outdated Show resolved Hide resolved
src/Header/Header.tsx Outdated Show resolved Hide resolved
src/AppBar/AppBar.tsx Outdated Show resolved Hide resolved
src/AppBar/AppBar.tsx Outdated Show resolved Hide resolved
src/AppBar/AppBar.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@steppy452 steppy452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments around flexibility of the AppBar content

@nickhowell6425
Copy link
Contributor Author

@steppy452 Updated, thanks!

Copy link
Contributor

@steppy452 steppy452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's beautiful 🎉

@nickhowell6425 nickhowell6425 merged commit bcb3e2a into master Feb 17, 2025
5 checks passed
@nickhowell6425 nickhowell6425 deleted the feature/header-component-and-cleanup branch February 17, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants