Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Doc] Remove graph property for buffer host lifetime #311

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

EwanC
Copy link
Collaborator

@EwanC EwanC commented Aug 28, 2023

Addressed Greg's most recent feedback points:

* [Don't need the
  assume_data_outlives_buffer](intel#10473 (comment))
* [Move graph_support_level
namespace](intel#10473 (comment))
@EwanC EwanC added Graph Specification Extension Specification related cherry-pick labels Aug 28, 2023
EwanC added a commit that referenced this pull request Aug 28, 2023
Implements spec feedback to remove this property, goes with
spec PR #311
EwanC added a commit that referenced this pull request Aug 28, 2023
Move the `graph_support_level` enum from
`sycl::ext::oneapi::experimental::info` to
`sycl::ext::oneapi::experimental`

Reflects changes from specification PR #311
@EwanC EwanC merged commit 25b036f into pablo/promote-graph-spec Aug 28, 2023
@EwanC EwanC deleted the ewan/remove_data_property branch August 28, 2023 10:44
EwanC added a commit that referenced this pull request Aug 28, 2023
Implements spec feedback to remove this property, goes with
spec PR #311
EwanC added a commit that referenced this pull request Aug 28, 2023
* [SYCL][Graph] Move `graph_support_level` namespace

Move the `graph_support_level` enum from
`sycl::ext::oneapi::experimental::info` to
`sycl::ext::oneapi::experimental`

Reflects changes from specification PR #311

* Give explicit values to enum class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Graph Specification Extension Specification related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants