fix: release workflow #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
reviewed
Jan 24, 2024
smrz2001
reviewed
Jan 24, 2024
3benbox
force-pushed
the
fix-create-release
branch
from
6e50181 to
f88b0c4
Compare
smrz2001
reviewed
Jan 25, 2024
smrz2001
reviewed
Jan 25, 2024
Added ssl dev Added openssl and pkg-config installs disable mac builds Added gh release step fix artifact path rename release file bump version to test releaes vendor openssl for static linking vendor openssl for static linking move openssl static to hermetic cargo.toml Update .github/workflows/create-release.yml Co-authored-by: Mohsin Zaidi <[email protected]> trying out mac Try brew install openssl artifact mac Added docker image Added tag output for release Disable linux arm64 trying github image repo Use AWS ECR public repo fix: address comments, build binaries fix: dupe key name fix: dupe key name fix: dependency fix: added ending space fix: use build tag for image fix: tag problems
3benbox
force-pushed
the
fix-create-release
branch
from
b59d3f7 to
9f9e08c
Compare
smrz2001
approved these changes
Jan 29, 2024
| @@ -45,6 +45,12 @@ jobs: | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - name: Install libssl-dev | |||
| if: matrix.target == 'x86_64-unknown-linux-gnu' | |||
| run: sudo apt-get install libssl-dev pkg-config | |||
There was a problem hiding this comment.
You can move the command to a "build-command" entry in the strategy matrix. Then here, you'd just need to invoke the command ($(${{ matrix.build-command }})?).
| publish-hermetic-driver: | ||
| IMAGE_NAME=${TEST_SUITE_IMAGE_NAME} ./ci-scripts/publish_hermetic_driver.sh ${BUILD_TAG} | ||
|
|
||
| # TODO Remove this target when the flavors are refactored away |
There was a problem hiding this comment.
I think you can remove this section now after Nathaniel's latest PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statically compile openssl for the hermetic driver release.
Fixed the release steps.