-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup ssh keys for ci #216
base: main
Are you sure you want to change the base?
Conversation
the deps have Line 72 in e5944f3
|
cli/src/node.rs
Outdated
@@ -0,0 +1,46 @@ | |||
// Copyright 2024 Hoku Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unneeded file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not supposed to be in the PR, my bad
e5944f3
to
d64a0d4
Compare
Sander mentioned he is working on a PR to get the upstream changes to |
${{ secrets.BUILTIN_ACTORS_DEPLOY_KEY }} | ||
${{ secrets.CONTRACTS_DEPLOY_KEY }} | ||
${{ secrets.ENTANGLEMENT_DEPLOY_KEY }} | ||
${{ secrets.TODO }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this supposed to do? note, there are a bunch more of these ssh-agent actions in the repo
@joewagner you should be able to use http instead of ssh in the Cargo.toml file now that the repos are open. but, may as well just wait until |
ah yeah external ppl are running into issues (e.g., someone opened a ticket in discord). if we wanna make it work now vs later, i opened a PR for just changing the ssh deps to https: #218 |
Now that this repo is public we don't need the
webfactory/ssh-agent
step in the ci workflow.This removes that step.