Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup ssh keys for ci #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: cleanup ssh keys for ci #216

wants to merge 1 commit into from

Conversation

joewagner
Copy link
Contributor

Now that this repo is public we don't need the webfactory/ssh-agent step in the ci workflow.
This removes that step.

@dtbuchholz
Copy link
Contributor

the deps have ssh in the path, so i think we can just remove that

fendermint_actor_blobs_shared = { git = "ssh://[email protected]/recallnet/ipc.git", rev = "571bca5e928e9bd00f27517517b40aea2b8df31c" }

cli/src/node.rs Outdated
@@ -0,0 +1,46 @@
// Copyright 2024 Hoku Contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not supposed to be in the PR, my bad

@joewagner joewagner changed the title fix: remove the ssh step from ci workflow fix: cleanup ssh keys for ci Feb 21, 2025
@joewagner
Copy link
Contributor Author

the deps have ssh in the path, so i think we can just remove that

fendermint_actor_blobs_shared = { git = "ssh://[email protected]/recallnet/ipc.git", rev = "571bca5e928e9bd00f27517517b40aea2b8df31c" }

Sander mentioned he is working on a PR to get the upstream changes to ipc merged so we can remove these ssh deps. Until that happens I guess we need the ssh step in the CI workflow. I don't have access to the repo's settings, so I can't fix this while there are ssh key deps. In the mean time I'll leave this PR open as a reminder.

${{ secrets.BUILTIN_ACTORS_DEPLOY_KEY }}
${{ secrets.CONTRACTS_DEPLOY_KEY }}
${{ secrets.ENTANGLEMENT_DEPLOY_KEY }}
${{ secrets.TODO }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this supposed to do? note, there are a bunch more of these ssh-agent actions in the repo

@sanderpick
Copy link
Contributor

@joewagner you should be able to use http instead of ssh in the Cargo.toml file now that the repos are open. but, may as well just wait until ipc, entanglement, etc. are crates, and use those here

@dtbuchholz
Copy link
Contributor

ah yeah external ppl are running into issues (e.g., someone opened a ticket in discord).

if we wanna make it work now vs later, i opened a PR for just changing the ssh deps to https: #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants