Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error #203

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

nixpanic
Copy link
Member

Backport of ceph#3854, to include the following commits:

  • rbd: add check for EncryptionTypeNone
  • rbd: remove context where its not being used
  • rbd: add e2e for encryption as false
  • rbd: add unit test for ParseEncryptionOpts

I hereby confirm that:

this commit adds the validation for encryption
value as false, and sets the type as none

Signed-off-by: riya-singhal31 <[email protected]>
(cherry picked from commit 38f5e86)
Signed-off-by: riya-singhal31 <[email protected]>
(cherry picked from commit 347b4d2)
Signed-off-by: riya-singhal31 <[email protected]>
(cherry picked from commit e92edd0)
Signed-off-by: riya-singhal31 <[email protected]>
(cherry picked from commit b5e68c8)
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

@nixpanic: This pull request references Bugzilla bug 2246388, which is invalid:

  • expected the bug to target the "ODF 4.13.5" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Its a good idea label Oct 30, 2023
@nixpanic
Copy link
Member Author

nixpanic commented Nov 2, 2023

/bugzilla refresh

Copy link

openshift-ci bot commented Nov 2, 2023

@nixpanic: This pull request references Bugzilla bug 2246388, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 2, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@nixpanic: This pull request references Bugzilla bug 2246388, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member Author

nixpanic commented Nov 2, 2023

/assign Madhu-1

Please check and add /lgtm

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Nov 2, 2023
Copy link

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit e2ec995 into red-hat-storage:release-4.13 Nov 2, 2023
8 of 10 checks passed
Copy link

openshift-ci bot commented Nov 2, 2023

@nixpanic: All pull requests linked via external trackers have merged:

Bugzilla bug 2246388 has been moved to the MODIFIED state.

In response to this:

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants