Syncing latest changes from devel for ceph-csi #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the deprecated grpc related code from cephcsi. fixes: ceph#4122 Signed-off-by: Madhu Rajanna <[email protected]>
re-arrange the struct members to fix below lint issue ``` struct of size 336 bytes could be of size 328 bytes ``` Signed-off-by: Madhu Rajanna <[email protected]>
Keeping track of changes between releases and fetching that information during release is difficult, Adding a doc to keep track of the changes between major releases which helps during release. Signed-off-by: Madhu Rajanna <[email protected]>
tickgit.com identifies `XXX` as label for TODO's. There is no need to list the `digest` hash examples in the TODO list, so replace the `XXX` and `YYY` examples with `XYZ` and `ZYX`. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
The HealthChecker is configured to use the Staging path pf the volume, with a `.csi/` subdirectory. In the future this directory could be a directory that is not under the Published directory. Fixes: ceph#4219 Signed-off-by: Niels de Vos <[email protected]>
When FilesystemNodeGetVolumeStats() succeeds, the volume must be healthy. This can be included in the VolumeCondition CSI message by default. Checks that detect an abnormal VolumeCondition should prevent calling FilesystemNodeGetVolumeStats() as it is possible that the function will hang. Signed-off-by: Niels de Vos <[email protected]>
update the e2e code to add multiple labels to the node at a time. fixes: ceph#4146 Signed-off-by: Madhu Rajanna <[email protected]>
update the e2e code to remove multiple labels to the node at a time. Signed-off-by: Madhu Rajanna <[email protected]>
df-build-team
force-pushed
the
sync_us--devel
branch
from
bfa7dc8 to
5576800
Compare
As we are using latest version of go-ceph which doesnt require any special tags for the API's cephcsi is consuming. Signed-off-by: Madhu Rajanna <[email protected]>
remove RadosNamespace from the configmap main section as its already added to the rbd section Signed-off-by: Madhu Rajanna <[email protected]>
remove support for deprecated rbdImageRequiresEncryption case. Signed-off-by: Madhu Rajanna <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from devel branch