Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2249601: cephfs: set Pool parameter to empty for Snapshot-backed volumes #215

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #214

/assign nixpanic

Set VolumeOptions.Pool parameter to empty for Snapshot-backed volumes.
This Pool parameter is optional and  only used as 'pool-layout' parameter
during subvolume and subvolume clone create request in cephcsi
and not used for Snapshot-backed volume at all.
It is not saved anywhere for use in subsequent operations after create too.
Therefore, We can set it to empty and not error out.

Signed-off-by: rakshith-r <[email protected]>
(cherry picked from commit f1e9d80)
@nixpanic
Copy link
Member

/retitle BUG 2249601: cephfs: set Pool parameter to empty for Snapshot-backed volumes

@openshift-ci openshift-ci bot changed the title [release-4.13] BUG 2249600: cephfs: set Pool parameter to empty for Snapshot-backed volumes BUG 2249601: cephfs: set Pool parameter to empty for Snapshot-backed volumes Nov 14, 2023
Copy link

openshift-ci bot commented Nov 14, 2023

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2249601, which is invalid:

  • expected the bug to target the "ODF 4.13.5" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2249601: cephfs: set Pool parameter to empty for Snapshot-backed volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Nov 14, 2023
Copy link

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nixpanic, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Nov 14, 2023
@nixpanic
Copy link
Member

/bugzilla refresh

Copy link

openshift-ci bot commented Nov 14, 2023

@nixpanic: This pull request references Bugzilla bug 2249601, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 14, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@nixpanic: This pull request references Bugzilla bug 2249601, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.5) matches configured target release for branch (ODF 4.13.5)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 162787c into red-hat-storage:release-4.13 Nov 14, 2023
8 of 10 checks passed
Copy link

openshift-ci bot commented Nov 14, 2023

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2249601 has been moved to the MODIFIED state.

In response to this:

BUG 2249601: cephfs: set Pool parameter to empty for Snapshot-backed volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants