Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from release-v3.10 for ceph-csi #229

Merged
merged 75 commits into from
Dec 7, 2023

Conversation

Nikhil-Ladha
Copy link
Member

PR containing the latest commits from release-v3.10 branch

Madhu-1 and others added 30 commits November 3, 2023 10:04
This commit removes the deprecated
grpc related code from cephcsi.

fixes: #4122

Signed-off-by: Madhu Rajanna <[email protected]>
re-arrange the struct members to
fix below lint issue

```
struct of size 336 bytes could be of size 328 bytes
```

Signed-off-by: Madhu Rajanna <[email protected]>
Keeping track of changes between releases
and fetching that information during
release is difficult, Adding a doc to
keep track of the changes between major
releases which helps during release.

Signed-off-by: Madhu Rajanna <[email protected]>
tickgit.com identifies `XXX` as label for TODO's. There is no need to
list the `digest` hash examples in the TODO list, so  replace the `XXX`
and `YYY` examples with `XYZ` and `ZYX`.

Signed-off-by: Niels de Vos <[email protected]>
The HealthChecker is configured to use the Staging path pf the volume,
with a `.csi/` subdirectory. In the future this directory could be a
directory that is not under the Published directory.

Fixes: #4219
Signed-off-by: Niels de Vos <[email protected]>
When FilesystemNodeGetVolumeStats() succeeds, the volume must be
healthy. This can be included in the VolumeCondition CSI message by
default.

Checks that detect an abnormal VolumeCondition should prevent calling
FilesystemNodeGetVolumeStats() as it is possible that the function will
hang.

Signed-off-by: Niels de Vos <[email protected]>
update the e2e code to add multiple
labels to the node at a time.

fixes: #4146

Signed-off-by: Madhu Rajanna <[email protected]>
update the e2e code to remove multiple
labels to the node at a time.

Signed-off-by: Madhu Rajanna <[email protected]>
As we are using latest version of go-ceph
which doesnt require any special tags
for the API's cephcsi is consuming.

Signed-off-by: Madhu Rajanna <[email protected]>
remove RadosNamespace from the configmap main
section as its already added to the rbd section

Signed-off-by: Madhu Rajanna <[email protected]>
remove support for deprecated
rbdImageRequiresEncryption case.

Signed-off-by: Madhu Rajanna <[email protected]>
The ReplicationServer is not used anymore, the functionality has moved
to CSI-Addons and the `internal/csi-addons/rbd` package. These last
references were not activated anywhere, so can be removed without any
impact.

See-also: #3314
Signed-off-by: Niels de Vos <[email protected]>
updating the PendingReleaseNotes.md to
mark the grpc flag's removal.

Signed-off-by: Madhu Rajanna <[email protected]>
disable ganesha as dnf update is
failing on Reef ceph version.

Signed-off-by: Madhu Rajanna <[email protected]>
The `tickgit.com` webservice seems to not update itself anymore, but
having a list of TODO's is very useful. Use the tickgit project to
gather the TODO's, bit in a GitHub Workflow.

Developers can also run `make containerized-test TARGET=tickgit` to get
the result locally.

Signed-off-by: Niels de Vos <[email protected]>
fixed spellcheck errors caught in
CI.

Signed-off-by: Madhu Rajanna <[email protected]>
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: #4218

Signed-off-by: Madhu Rajanna <[email protected]>
Avoiding variable shadowing as it
becomes hard to debug this kind of
issues in real enviroment.

Signed-off-by: Madhu Rajanna <[email protected]>
This commit adds util functions related to read affinity
and unit testcases for the same.

Signed-off-by: Praveen M <[email protected]>
Implemented the capability to include read affinity options
for individual clusters within the ceph-csi-config ConfigMap.
This allows users to configure the crush location for each
cluster separately. The read affinity options specified in
the ConfigMap will supersede those provided via command line arguments.

Signed-off-by: Praveen M <[email protected]>
Allow templating of stripeUnit, stripeCount and objectSize
storageClass parameters in ceph-csi-rbd chart

Signed-off-by: Kingsley Jarrett <[email protected]>
Ceph is minimizing their container-images, which can cause the
`nfs-utils` package to be dropped. As Ceph-CSI supports mounting NFS, it
needs the `/sbin/mount.nfs` executable, so install the package (or a
no-op if it is installed already).

See-also: https://rook-io.slack.com/archives/C46Q5UC05/p1699188662893109
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Domonkos Cinke <[email protected]>
To use mutating webhook to modify secrets.
For example banzaicloud vault webhook:
https://bank-vaults.dev/docs/mutating-webhook/annotations/

Signed-off-by: Ruslan Khizhnyak <[email protected]>
iPraveenParihar and others added 21 commits November 22, 2023 13:13
This commit adds documentation about read affinity supported
for CephFS subvolumes.

Signed-off-by: Praveen M <[email protected]>
this will auto assign the issue to the user who
commented /assign

Signed-off-by: Riya Singhal <[email protected]>
this commit updates the version of go-ceph imported to
latest, so we can make use of github.com/ceph/go-ceph/cephfs

Signed-off-by: Riya Singhal <[email protected]>
this commit replaces string comparsion with error code
at few places

Signed-off-by: Riya Singhal <[email protected]>
Updating the support matrix to point to the suppotred ceph release.

Fixes: #4168
Signed-off-by: karthik-us <[email protected]>
The ceph fs subvolume resize support is available
in all the active ceph releases. Hence removing the
code to check the supportability of the feature.

Signed-off-by: karthik-us <[email protected]>
Adding a note on supported ceph releases.

Signed-off-by: karthik-us <[email protected]>
To deploy additional manifests with the release.

Signed-off-by: Ruslan Khizhnyak <[email protected]>
The commit enables the featuregate for volume expansion recovery
in NFS.

Signed-off-by: Praveen M <[email protected]>
This commit exposes CSI ConfigMap over an API.
This will allow projects like Rook to consume CSI configMap
directly from Ceph-CSI.

Signed-off-by: Praveen M <[email protected]>
This is to pre-emptively add check for EAGAIN error returned from
ceph as part of ceph/ceph#52670 if all the
clone threads are busy and return csi compatible error.

Fixes: #3996
Signed-off-by: karthik-us <[email protected]>
No major changes that affect Ceph-CSI testing, see the linked release
notes for details.

See-also: https://github.com/kubernetes/minikube/releases/tag/v1.32.0
Signed-off-by: Niels de Vos <[email protected]>
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.14.0 to 0.15.0.
- [Commits](golang/oauth2@v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the golang-dependencies group with 2 updates: [golang.org/x/crypto](https://github.com/golang/crypto) and [golang.org/x/net](https://github.com/golang/net).


Updates `golang.org/x/crypto` from 0.15.0 to 0.16.0
- [Commits](golang/crypto@v0.15.0...v0.16.0)

Updates `golang.org/x/net` from 0.18.0 to 0.19.0
- [Commits](golang/net@v0.18.0...v0.19.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the github-dependencies group with 2 updates: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) and [github.com/aws/aws-sdk-go-v2/service/sts](https://github.com/aws/aws-sdk-go-v2).


Updates `github.com/aws/aws-sdk-go` from 1.48.0 to 1.48.5
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.48.0...v1.48.5)

Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.25.3 to 1.25.4
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.25.3...config/v1.25.4)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sts
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
This commit updates README to deprecate 3.8.x release
and pin latest release to v3.10.0

Signed-off-by: Rakshith R <[email protected]>
This commit adds steps for upgrading from 3.9
to 3.10.

Signed-off-by: Rakshith R <[email protected]>
This commit updates templates to new
v3.10.0 release.
Pending Release Notes is also reset.

Signed-off-by: Rakshith R <[email protected]>
This commit adds rules for release-v3.10
and removes rules for release-v3.8.

Signed-off-by: Rakshith R <[email protected]>
This commit makes template changes for
3.10 release branch to use 3.10-canary tag.

Signed-off-by: Rakshith R <[email protected]>
@Nikhil-Ladha
Copy link
Member Author

I have created this PR manually, because auto-sync (i.e, rebase) isn't feasible anymore as we have switched to an upstream branch that doesn't have few changes that are present in the release-4.15 branch.
I will comment out the ceph-csi branch sync for the time being, and continue with other repos.

@Rakshith-R
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Dec 7, 2023
Copy link

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Nikhil-Ladha, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Dec 7, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 027f8b6 into red-hat-storage:release-4.15 Dec 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants