Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #257

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

riya-singhal31 and others added 9 commits February 15, 2024 08:22
updating csi snapshotter deployment to pull
image and rbac from latest released version.

Signed-off-by: Madhu Rajanna <[email protected]>
Install latest version of snapshotter and also
take care of create/delete of new CRD's and
required flag for volumegroupsnapshot operation

Signed-off-by: Madhu Rajanna <[email protected]>
remove unused function from the
install-snapshot script

Signed-off-by: Madhu Rajanna <[email protected]>
canary tag is no more used in the
snapshotter yaml and latest version are
used, instead of searching for tag check
for the image name and do sed to replace
the required tag only.

Signed-off-by: Madhu Rajanna <[email protected]>
use kubectl_retry helper to avoid
intermediate failure and retry again

Signed-off-by: Madhu Rajanna <[email protected]>
with new release of snapshotter the
labels are changed, this commit uses
the new labels to list the snapshot
controller pod.

Signed-off-by: Madhu Rajanna <[email protected]>
@df-build-team df-build-team requested a review from a team February 16, 2024 08:04
@Madhu-1
Copy link
Member

Madhu-1 commented Feb 16, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Feb 16, 2024
Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Feb 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 96f0303 into devel Feb 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants