Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync 'odf/devel' into ds/sync/release-4.16 #282

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

nixpanic
Copy link
Member

Automatic syncing checks the date of the most recent change, and if it
is more recent than the change from the source (devel) branch, it won't
create a PR. Doing that manually now.

if rbd storage class is created with topologyconstraintspools
replicated pool was still mandatory, making the pool optional if the
topologyconstraintspools is requested

Closes: #4380

Signed-off-by: parth-gr <[email protected]>
Copy link

openshift-ci bot commented Mar 27, 2024

@nixpanic: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Sync 'odf/devel' into ds/sync/release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Its a good idea label Mar 27, 2024
@Madhu-1
Copy link
Member

Madhu-1 commented Mar 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Mar 27, 2024
Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f3536d7 into red-hat-storage:release-4.16 Mar 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea bugzilla/valid-bug lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants