Syncing latest changes from devel for ceph-csi #286
Conversation
df-build-team
force-pushed
the
sync_ds--devel
branch
from
f3536d7 to
ab947bb
Compare
|
@df-build-team: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
strange, golangci-lint fails here, but not in upstream? |
Just like GenVolFromVolID() the genSnapFromSnapID() function can return a snapshot. There is no need to allocated an empty snapshot and pass that to the genSnapFromSnapID() function. Signed-off-by: Niels de Vos <[email protected]>
Not all snapshot objects are free'd correctly after they were allocated. It is possible that some connections to the Ceph cluster were never closed. This does not need to be a noticeable problem, as connections are re-used where possible, but it isn't clean either. Signed-off-by: Niels de Vos <[email protected]>
By returning a connected rbdVolume in parseVolCreateRequest(), the CreateVolume() function can be simplified a little. There is no need to call the additional Connect() and detect failures with it. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
This commit fixes the typo from `.Values.seLinuxMount` to `.Values.CSIDriver.seLinuxMount` used in helm charts. Signed-off-by: Praveen M <[email protected]>
The "slices" package has been introduced in Go 1.21 and can be used instead of the Kubernetes package that will be replaced by the standard package at one point too. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Praveen M <[email protected]>
|
Attempt to fix the CI failure
Inspection of the
Pushed the updated commits to the branch for this PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is the latest auto-sync PR for release-4.16. Added the |
PR containing the latest commits from devel branch