Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2266237: cleanup: incorrect fuserecovery logging #303

Merged

Conversation

iPraveenParihar
Copy link
Member

cleanup: incorrect fuserecovery logging
This commit make sure that logs fuserecovery.go is only logged
when the chosen mount is FUSE.

(cherry picked from commit 0e61b82)

Copy link

openshift-ci bot commented May 8, 2024

@iPraveenParihar: Bugzilla bug 2266237 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

BUG 2266237: cleanup: incorrect fuserecovery logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Its a good idea label May 8, 2024
@iPraveenParihar iPraveenParihar requested a review from Rakshith-R May 8, 2024 11:21
@Madhu-1
Copy link
Member

Madhu-1 commented May 8, 2024

add this extra commit 60e2527 to have CI green

@agarwal-mudit
Copy link
Member

/bugzilla refresh

Copy link

openshift-ci bot commented May 8, 2024

@agarwal-mudit: This pull request references Bugzilla bug 2266237, which is invalid:

  • expected the bug to target the "ODF 4.16.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nixpanic and others added 2 commits May 9, 2024 14:53
It seems GitHub has an issue with the Fedora 40 container image,
extracting the Golang tarball fails. The Fedora 39 image does not have
this problem, so use that for the time being.

Signed-off-by: Niels de Vos <[email protected]>
(cherry picked from commit 60e2527)
Signed-off-by: Praveen M <[email protected]>
(cherry picked from commit 0e61b82)
@iPraveenParihar
Copy link
Member Author

removing commit to update golangci-lint as it requires all the commits from https://github.com/ceph/ceph-csi/pull/4539/commits

@Rakshith-R , can we merge this PR for now? And update golangci-lint version in another PR?

@iPraveenParihar
Copy link
Member Author

/bugzilla refresh

Copy link

openshift-ci bot commented May 9, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2266237, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rakshith-R
Copy link
Member

removing commit to update golangci-lint as it requires all the commits from https://github.com/ceph/ceph-csi/pull/4539/commits

@Rakshith-R , can we merge this PR for now? And update golangci-lint version in another PR?

ack
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label May 9, 2024
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iPraveenParihar, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Rakshith-R,iPraveenParihar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 46e4e3f into red-hat-storage:release-4.16 May 9, 2024
9 of 10 checks passed
Copy link

openshift-ci bot commented May 9, 2024

@iPraveenParihar: All pull requests linked via external trackers have merged:

Bugzilla bug 2266237 has been moved to the MODIFIED state.

In response to this:

BUG 2266237: cleanup: incorrect fuserecovery logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants