Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #307

Merged
merged 8 commits into from
May 27, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

dependabot bot and others added 7 commits May 24, 2024 09:27
Bumps the k8s-dependencies group with 1 update in the / directory: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).

Updates `sigs.k8s.io/controller-runtime` from 0.17.3 to 0.18.2
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.17.3...v0.18.2)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
dropping go version from the go mod
as we have x.y.z version for go

Signed-off-by: Madhu Rajanna <[email protected]>
updating kubernetes to 1.30 release

Signed-off-by: Madhu Rajanna <[email protected]>
update kubernetes and go version in api folder.

Signed-off-by: Madhu Rajanna <[email protected]>
changes as per new controller runtime import

Signed-off-by: Madhu Rajanna <[email protected]>
fixing logging as per new controller runtime
errors

Signed-off-by: Madhu Rajanna <[email protected]>
@df-build-team df-build-team requested a review from a team May 25, 2024 08:00
ensure a clean and isolated environment for testing purposes.

Signed-off-by: Mayank Pal <[email protected]>

ci: Use temporary directory for unit tests

remove err = os.Mkdir('/etc/ceph-csi-config', 0o600)

Signed-off-by: Mayank Pal <[email protected]>

ci: Use temporary directory for unit tests

remove err = os.Mkdir('/etc/ceph-csi-config', 0o600)

Signed-off-by: Mayank Pal <[email protected]>

ci: Use temporary directory for unit tests

remove if err

Signed-off-by: Mayank Pal <[email protected]>
@Madhu-1
Copy link
Member

Madhu-1 commented May 27, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label May 27, 2024
Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label May 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cda2165 into devel May 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants