Syncing latest changes from upstream devel for ceph-csi #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Below sidecars are updated with latest available versions csi-node-driver-registrar: v2.10.1 csi-resizer: v1.11.1 csi-provisioner: v5.0.1 csi-attacher: v4.6.1 csi-snapshotter: v8.0.1 Signed-off-by: Praveen M <[email protected]>
This commit remove `VOLUME_ACCESSIBILITY_CONSTRAINTS` capabilities from CephFS as topology based volume provisioning is not yet supported. Signed-off-by: Praveen M <[email protected]>
This commit removes the Topology feature gate as it is now enabled by default and will be removed in a future release. It is CSI driver's responsibility to report capability `VOLUME_ACCESSIBILITY_CONSTRAINTS` so that topology gets enabled in external-provisioner. When driver doesn't report it, external-provisioner disables topology support. As of this change, Only RBD driver supports topology based volume provisioning and it reports the `VOLUME_ACCESSIBILITY_CONSTRAINTS` capability, enabling topology support in the external-provisioner. Signed-off-by: Praveen M <[email protected]>
This commit removes the Topology feature gate as it is now enabled by default and will be removed in a future release. Signed-off-by: Praveen M <[email protected]>
This commit removes `enableTopologyInTemplate` method as this is not needed anymore. Signed-off-by: Praveen M <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch