Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #353

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

nixpanic and others added 5 commits August 1, 2024 08:31
GitHub had issues with Fedora 40 when it was released. Hopefully this is
not the case anymore.

Closes: ceph#4585
Signed-off-by: Niels de Vos <[email protected]>
Fedora 40 builds seems to require disabling seccomp. When enabled,
installing Golang inside the container fails.

See-also: containers/podman#21012
Signed-off-by: Niels de Vos <[email protected]>
There has been some confusion about using different variables for the
InstanceID of the RBD-driver. By removing the global variable
CSIInstanceID, there should be no confusion anymore what variable to
use.

Signed-off-by: Niels de Vos <[email protected]>
RBD does not have a global CSIInstanceID variable anymore, there is no
need for CephFS to use one either.

Signed-off-by: Niels de Vos <[email protected]>
@df-build-team df-build-team requested a review from a team August 6, 2024 08:04
@nixpanic
Copy link
Member

nixpanic commented Aug 6, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Aug 6, 2024
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8a7bb4c into devel Aug 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants