Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2303181: util: exclude empty label values for crushlocation map #355

Merged

Conversation

iPraveenParihar
Copy link
Member

Describe what this PR does

This commit resolves a bug where node labels with empty values
are processed for the crush_location mount option,
leading to invalid mount options and subsequent mount failures.


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

This commit resolves a bug where node labels with empty values
are processed for the crush_location mount option,
leading to invalid mount options and subsequent mount failures.

Signed-off-by: Praveen M <[email protected]>
(cherry picked from commit f11fa81)
Copy link

openshift-ci bot commented Aug 6, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2297265, which is invalid:

  • expected the bug to target the "ODF 4.15.6" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2297265: util: exclude empty label values for crushlocation map

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iPraveenParihar iPraveenParihar changed the title BUG 2297265: util: exclude empty label values for crushlocation map BUG 2303181: util: exclude empty label values for crushlocation map Aug 6, 2024
Copy link

openshift-ci bot commented Aug 6, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is invalid:

  • expected the bug to target the "ODF 4.15.6" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2303181: util: exclude empty label values for crushlocation map

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iPraveenParihar
Copy link
Member Author

/bugzilla refresh

Copy link

openshift-ci bot commented Sep 5, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is invalid:

  • expected the bug to target the "ODF 4.15.6" release, but it targets "ODF 4.15.7" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iPraveenParihar
Copy link
Member Author

/bugzilla refresh

Copy link

openshift-ci bot commented Sep 9, 2024

@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.7) matches configured target release for branch (ODF 4.15.7)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 9, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.7) matches configured target release for branch (ODF 4.15.7)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Fedora 40 builds seems to require disabling seccomp. When enabled,
installing Golang inside the container fails.

See-also: containers/podman#21012
Signed-off-by: Niels de Vos <[email protected]>
(cherry picked from commit db6f54f)
@iPraveenParihar
Copy link
Member Author

/cc @Madhu-1 @Rakshith-R

@openshift-ci openshift-ci bot requested review from Madhu-1 and Rakshith-R September 9, 2024 10:41
@iPraveenParihar
Copy link
Member Author

@Madhu-1, do we want codespell to be fixed in this PR or a Separate?

@Madhu-1
Copy link
Member

Madhu-1 commented Sep 9, 2024

@Madhu-1, do we want codespell to be fixed in this PR or a Separate?

@iPraveenParihar lets fix it in this PR itself, please add a commit for it as well.

fixed codespell problems found
in the CI run

Signed-off-by: Madhu Rajanna <[email protected]>
(cherry picked from commit bdd4c07)
@Madhu-1
Copy link
Member

Madhu-1 commented Sep 9, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Sep 9, 2024
Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iPraveenParihar, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Sep 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3aa8452 into red-hat-storage:release-4.15 Sep 9, 2024
10 checks passed
Copy link

openshift-ci bot commented Sep 9, 2024

@iPraveenParihar: All pull requests linked via external trackers have merged:

Bugzilla bug 2303181 has been moved to the MODIFIED state.

In response to this:

BUG 2303181: util: exclude empty label values for crushlocation map

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants