-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 2303181: util: exclude empty label values for crushlocation map #355
BUG 2303181: util: exclude empty label values for crushlocation map #355
Conversation
This commit resolves a bug where node labels with empty values are processed for the crush_location mount option, leading to invalid mount options and subsequent mount failures. Signed-off-by: Praveen M <[email protected]> (cherry picked from commit f11fa81)
@iPraveenParihar: This pull request references Bugzilla bug 2297265, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/bugzilla refresh |
@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/bugzilla refresh |
@iPraveenParihar: This pull request references Bugzilla bug 2303181, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fedora 40 builds seems to require disabling seccomp. When enabled, installing Golang inside the container fails. See-also: containers/podman#21012 Signed-off-by: Niels de Vos <[email protected]> (cherry picked from commit db6f54f)
/cc @Madhu-1 @Rakshith-R |
@Madhu-1, do we want codespell to be fixed in this PR or a Separate? |
@iPraveenParihar lets fix it in this PR itself, please add a commit for it as well. |
fixed codespell problems found in the CI run Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit bdd4c07)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iPraveenParihar, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3aa8452
into
red-hat-storage:release-4.15
@iPraveenParihar: All pull requests linked via external trackers have merged: Bugzilla bug 2303181 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Describe what this PR does
This commit resolves a bug where node labels with empty values
are processed for the
crush_location
mount option,leading to invalid mount options and subsequent mount failures.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelatedfailure (please report the failure too!)