Syncing latest changes from upstream devel for ceph-csi #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In csi-external-provisioner: v5.0.1, topology-aware provisioning is enabled by default. As a result provisioner now expects toologyKeys to be present in CSINode object which must be passed by user via `--domainlabels` flag in RBD nodeplugin. Issue: Users upgrading to v3.12.0 who were not previously using topology-aware provisioning may encounter issues when provisionining RBD PVCs, as the `--domainlabels` flag might not be set. Fix: To address this, add `--immediate-topology=false` to disable topology-aware provisioning. User requiring topology-aware provisioning should provided the volumeBindingMode as `WaitForFirstConsumer` and `TopologyConstrainedPools` as required in the StorageClass and configure `--domainlabels` flag in RBD nodeplugin. Signed-off-by: Praveen M <[email protected]>
Signed-off-by: Praveen M <[email protected]>
we need to return the rbd image size as a snapshot size in CreateSnapshot Response. fixes: ceph#4788 Signed-off-by: Madhu Rajanna <[email protected]>
update mergify config to remove, replace the deprecated attributes. Signed-off-by: Nikhil-Ladha <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch