Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to update registry.conf #4426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obannak
Copy link

@obannak obannak commented Feb 5, 2025

Description

Adding/enabling insecure value and location in registry.conf

@obannak obannak requested review from a team as code owners February 5, 2025 14:37
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: obannak

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -423,6 +423,10 @@ def registry_login(ceph, distro_ver):
auths_dict = {"auths": auths}
ceph.exec_command(sudo=True, cmd="mkdir -p ~/.docker")
ceph.exec_command(cmd="mkdir -p ~/.docker")
ceph.exec_command(cmd="sudo grep -q '^\[\[registry\]\]' /etc/containers/registries.conf && \
sudo sed -i /etc/containers/registries.conf || echo -e '\n[[registry]]\nlocation = \"registry-....\"\ninsecure = true' | \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change registry-.... with registry-proxy.engineering.redhat.com

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vamahaja , @obannak
Can we please wait on this commit, as we are discussing few things on multi registry access,

  • Removal of docker directory is part of it.
  • working on different mechanism

cc: @psathyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants