Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ClusterRoleBinding to fetch in-cluster monitoring metrics #2892

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Create ClusterRoleBinding to fetch in-cluster monitoring metrics #2892

wants to merge 1 commit into from

Conversation

ezio-auditore
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ezio-auditore
Once this PR has been reviewed and has the lgtm label, please assign nbalacha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

umangachapagain
umangachapagain reviewed Nov 14, 2024
View reviewed changes
config/rbac/role.yaml
@@ -140,7 +140,9 @@ rules:
- monitoring.coreos.com
resources:
- alertmanagers
- k8s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this resource? Why is it required?

controllers/ocsinitialization/ocsinitialization_controller.go
r.Log.Error(err, "Failed to create/update K8s service monitor Cluster Role Binding")
return err
}
r.Log.Info("K8s cluster role binding creation succeeded", "Name", crb.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be more descriptive or can be dropped.

leelavg
leelavg reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should an operator create ClusterRoleBinding as that's the role of olm/admin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain left review comments

@leelavg leelavg leelavg left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezio-auditore @umangachapagain @leelavg