BUG 2259668: core: Continue processing PVs for network fencing when no node IPs found #574
Conversation
The cephfs PVC might exist on the kubernetes node object but due to some timing issues the ip might not be visible on the ceph cluster or the client might already got evicted or disconnected from ceph cluster. In this case we will not be able to get IP details for the subvolume and we dont have any check for empty ip's in the code and rook tries to create NetworkFence CR with empty Ip's and the NetworkFence will get moved to the Failed state. This PR adds the necessary check and logging to prevent this one. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit 0e115c4)
to keep the code consistent and to propogate more details about error rook uses error wraping. updating current code whereever its required to wrap the details. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit eb97390)
retry other cephfs/rbd pvc if there are no active clients found on ceph cluster. Signed-off-by: Madhu Rajanna <[email protected]> (cherry picked from commit ca21bd9)
openshift-ci
bot
added
bugzilla/severity-high
|
@Madhu-1: This pull request references Bugzilla bug 2259668, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @travisn |
|
Thanks for taking this issue! Let us know if you have any questions! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 2320def
into
red-hat-storage:release-4.15
|
@Madhu-1: All pull requests linked via external trackers have merged: Bugzilla bug 2259668 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The cephfs PVC might exist on the kubernetes node object but due to some timing issues the ip might not be visible on the ceph cluster or the client might have already been evicted or disconnected from the ceph cluster. In this case, we will not be able to get IP details for the subvolume and we don't have any check for empty ip's in the code rook tries to create NetworkFence CR with an empty Ip's, and the NetworkFence will get moved to the Failed state. This PR adds the necessary checks and logging to prevent this one.
Backport of rook#13768