Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: experiment around a hybrid (nacre) shell #333

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

o0Ignition0o
Copy link

@o0Ignition0o o0Ignition0o commented Mar 22, 2025

Super early draft, a lot of things to figure out together and document.

Coauthored by @regexident.

I hope I can draft a rough explainer of the various components soon ™️

TLDR:

  • One can register a callback crux must call to generate effects out of band (not within the request/response model)
  • The effect macro generates a NacreEffect implementation, depending on the sort of effect (notify_shell, request_from_shell, stream_from_shell)
  • Nacre is some sort of middleware that plugs between the core and the bridge, that has the ability to drive streams to completion.
  • NacreBridge deals with forwarding the effects via the callback
  • Probably more but i forgot, I ll try to draw a schema sometimes.

Next things I need to do:

  • turn the UDL based definition to a macro to please uniffi with the callback / trait registration
  • rebump dependencies
  • see what ideas are good and what ideas aren't
  • ???
  • profit

@o0Ignition0o o0Ignition0o marked this pull request as draft March 22, 2025 10:25
@@ -15,11 +15,17 @@ typegen = ["crux_core/typegen"]
crux_core.workspace = true
serde = { workspace = true, features = ["derive"] }
lazy_static = "1.5.0"
uniffi = "0.29.0"
uniffi = "=0.28.3"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope i can rebump these very soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant