Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes HockeyApp use #635

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Removes HockeyApp use #635

wants to merge 5 commits into from

Conversation

markholland
Copy link
Collaborator

fixes #631

Removes uploading builds to HockeyApp and querying for registered devices

Pre-flight check-list

Before raising a pull request

  • Documentation
  • Unit tests

Pre-merge check-list

  • Link to Trello ticket/GitHub issue (If applicable)
  • Any risky areas identified
  • Test plan provided
  • Tester approved

Tester check-list

  • Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

    • Galaxy S8 (Android 7.0/8.0)
    • Galaxy S7 (Android 6.0)
    • iPhone X (iOS 11.x)
    • iPhone 8 (11.x)
    • iPhone 7 (iOS 10.x)

    Optional:

    • Google Pixel 2
    • Galaxy S8 Plus
    • Galaxy S7 Edge
    • Galaxy S6
    • iPhone 7+
    • iPhone 6

Accessibility Testing (If applicable)

  • Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
  • Large Text (=<200%)
  • Landscape Screen orientation

Weak connection testing (If applicable)

  • Airplane mode
  • 2G/3G Network Settings

@markholland markholland requested review from robbiemccorkell and removed request for robbiemccorkell December 13, 2018 12:34
new_devices = get_unprovisioned_devices_from_hockey(app_bundle_id:'org.prideinlondon.festival', api_token:options[:api_token])
register_devices(devices: new_devices)
register_devices(devices: {
"Example device name" => "Example UUID",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding that as a code comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@callerc1 callerc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markholland
Copy link
Collaborator Author

No rush to merge this as still useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HockeyApp to be demised November 2019
2 participants