-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature branding aware configuration #2181
Feature branding aware configuration #2181
Conversation
Added AppConfig model and service to handle retrieval and persistence. Added bootstrap.js handler to initialise object and to bind convenience function to sails.config
…er forms using JSON Schema documents
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2181 +/- ##
===========================================
+ Coverage 52.11% 52.75% +0.64%
===========================================
Files 163 173 +10
Lines 8007 8264 +257
Branches 1147 1166 +19
===========================================
+ Hits 4173 4360 +187
- Misses 3403 3463 +60
- Partials 431 441 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR introduces a branding-aware configuration feature, enhancing the application's flexibility in handling multiple branding contexts. Key changes include:
Configuration Service: Added new service to manage branded app configurations.
API Endpoints: Introduced REST API endpoints for managing app configurations.
UI Enhancements: Implemented Angular components for configuration management, including a new app configuration screen. The Angular application uses Formly to generate forms using JSON Schema.
Configuration Storage: Configuration is stored in the database defined by config model objects. These config model objects are used to generate JSON Schema using the json-schema package.
Accessing Configurations: You can access the branding-aware configuration using sails.config.brandingAware(branding).
Testing: Added unit tests for the new services and components.
The first branding aware configuration implemented as a proof of concept is to add support for self-service system messages by administrator users