Implement mint legacy api endpoints #2201
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2201 +/- ##
===========================================
+ Coverage 53.24% 53.46% +0.22%
===========================================
Files 173 173
Lines 8266 8278 +12
Branches 1162 1166 +4
===========================================
+ Hits 4401 4426 +25
+ Misses 3421 3388 -33
- Partials 444 464 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| tests { | ||
|
|
||
| test("Status code is 200", function () { |
There was a problem hiding this comment.
Can you add some tests that check the response body is structured correctly?
config/routes.js
Outdated
| action: 'legacyHarvest', | ||
| csrf: false | ||
| }, | ||
| 'get /:branding/:portal/api/mint/harvest/search': { |
There was a problem hiding this comment.
We only need the ingest harvest. Search will be performed with existing endpoints already covered in the first work package. Future work package will cover getting the form components that search legacy Mint to be able to find the records inside ReDBox.
| @@ -137,6 +137,7 @@ export module Services { | |||
| searchString = ` AND (${queryString})`; | |||
| } | |||
|
|
|||
| //TODO instead of call external mint perform an Ajax call to ReDBOx or directly serach in the database for records or in the solr index ??? | |||
There was a problem hiding this comment.
Remove the TODO. I'm expecting this method will be left untouched when we search for records within ReDBox
There is currently a harvest endpoint defined which is quite similar but not exactly the same as the legacy Mint API. For future integrations we will push users towards the new endpoint but to allow a smooth transition we will need to provide backwards compatibility with the Mint API.