Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature web UI for lookup records #2249

Merged
merged 31 commits into from
Jun 27, 2024

Conversation

alejandro-bulgaris-qcif
Copy link
Contributor

@alejandro-bulgaris-qcif alejandro-bulgaris-qcif commented Jun 27, 2024

The web UI to show lookup records has two main areas and some additional changes:
1- The table view that required to implement changes in angular dashboard app. The main change in the dashboard was to add a feature to allow filtering of records
2- The detailed view for individual lookup records that required to implement a feature to autogenerate a dmp form based of the lookup record JSON schema
3- Additional changes were required in forms service and records service and records controllers for both the app records controller ajax call endpoint and the harvesting API endpoint

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 36.56716% with 85 lines in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (b82dfaf) to head (88812dc).
Report is 5 commits behind head on develop.

Files Patch % Lines
typescript/api/services/FormsService.ts 32.89% 51 Missing ⚠️
typescript/api/controllers/RecordController.ts 44.44% 18 Missing and 2 partials ⚠️
...ipt/api/controllers/webservice/RecordController.ts 0.00% 12 Missing ⚠️
typescript/api/services/WorkflowStepsService.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2249      +/-   ##
===========================================
- Coverage    55.51%   55.07%   -0.44%     
===========================================
  Files          173      173              
  Lines         8348     8524     +176     
  Branches      1177     1198      +21     
===========================================
+ Hits          4634     4695      +61     
- Misses        3501     3618     +117     
+ Partials       213      211       -2     
Flag Coverage Δ
backend-bruno 47.68% <20.89%> (-0.51%) ⬇️
backend-mocha 51.90% <36.56%> (-0.27%) ⬇️
frontend-app-config 97.87% <ø> (ø)
frontend-core-lib 52.41% <ø> (ø)
frontend-dashboard 79.31% <ø> (-8.77%) ⬇️
frontend-export 100.00% <ø> (ø)
frontend-local-auth 100.00% <ø> (ø)
frontend-manage-roles 63.33% <ø> (ø)
frontend-manage-users 59.81% <ø> (ø)
frontend-report 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit b3b953a into develop Jun 27, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants