-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature web UI for lookup records #2249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date range filters
… more promsify refactoring
…method in api record controller
…d fix all references
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2249 +/- ##
===========================================
- Coverage 55.51% 55.07% -0.44%
===========================================
Files 173 173
Lines 8348 8524 +176
Branches 1177 1198 +21
===========================================
+ Hits 4634 4695 +61
- Misses 3501 3618 +117
+ Partials 213 211 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web UI to show lookup records has two main areas and some additional changes:
1- The table view that required to implement changes in angular dashboard app. The main change in the dashboard was to add a feature to allow filtering of records
2- The detailed view for individual lookup records that required to implement a feature to autogenerate a dmp form based of the lookup record JSON schema
3- Additional changes were required in forms service and records service and records controllers for both the app records controller ajax call endpoint and the harvesting API endpoint