-
Notifications
You must be signed in to change notification settings - Fork 179
Replaced isfunction & ismethod with isroutine #707
base: develop
Are you sure you want to change the base?
Conversation
This pretty much returns exactly the same as before, but with the benefit of including C functions/methods. You can read more about that here: https://stackoverflow.com/a/17019998/6901146
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Please make sure CI passes.
Co-authored-by: Katie Atkinson <kaitlin@atkinson.mn>
@KTAtkinson so... I can't re-run the workflow since I am a "First-time contributor". Would you please do me the honors to approve the run? |
What do you think? Shall I adapt the test cases? (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the run but it looks like it failed :)
@KTAtkinson I have replaced |
Awesome! @KTAtkinson you need anything more from my end for this PR? (: Btw I'd really appreciate an "Open Sorcerer" trophy on my Reddit profile |
💇♀️ |
Nothing else needed from your end, we are working to get a critical feature out now, so I won't be able to release this for a bit. |
💇♀️ |
hi @KTAtkinson it looks like @aba-ca-xi isn't available (anymore?). Could you please assign another reviewer? |
@maeivysea maybe? |
@KTAtkinson when merge? |
This pretty much returns exactly the same as before, but with the benefit of including C functions/methods. You can read more about that here:
https://stackoverflow.com/a/17019998/6901146