Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Granite Model Template to granite-3.1 #61

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

maysunfaisal
Copy link
Contributor

What does this PR do?:

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/RHDHPAI-494

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

Use the template for testing https://github.com/maysunfaisal/ai-lab-template/blob/494-1_temp1_PRTEST/templates/model-server/template.yaml

Signed-off-by: Maysun J Faisal <[email protected]>
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I will review the PR on dev images as well once the PR check passes. We should think about merging dev images first before this so that the image is present in the quay repo

@maysunfaisal
Copy link
Contributor Author

maysunfaisal commented Jan 20, 2025

lgtm, I will review the PR on dev images as well once the PR check passes. We should think about merging dev images first before this so that the image is present in the quay repo

@Jdubrick I manually pushed the image to the repo as I had to test the image

@Jdubrick
Copy link
Contributor

lgtm, I will review the PR on dev images as well once the PR check passes. We should think about merging dev images first before this so that the image is present in the quay repo

@Jdubrick I manually pushed the image to the repo as I had to test the image

Ah yeah I see it in the repo now, this should be good then

@maysunfaisal maysunfaisal merged commit c71cfeb into redhat-ai-dev:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants