-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Knative Event, KubeArchive dependency, as infra component #4764
Add Knative Event, KubeArchive dependency, as infra component #4764
Conversation
I will submit corrections for the kube-lint problems. |
82f8706
to
4d9cf61
Compare
Quick feedback: you should add an |
argo-cd-apps/base/all-clusters/infra-deployments/knative-eventing/knative-eventing.yaml
Outdated
Show resolved
Hide resolved
I think you may be missing important bits in |
4d9cf61
to
a91c47f
Compare
Signed-off-by: Hector Martinez <[email protected]>
a91c47f
to
973ebdb
Compare
/lgtm |
@rh-hemartin this looks good to me, but I'd like @hugares to ack it as well to minimize any surprises. |
I have a packed morning, I will check this later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, rh-hemartin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e81ca85
into
redhat-appstudio:main
@rh-hemartin The knative application deployed but there a sync loop, some cluster role are out of sync, then sync, then out of sync and so on. I did not have time to look into this, please have a look |
I'm adding Knative Eventing because its a dependency for KubeArchive. There was an ADR to install it for everyone use, but my intention here is that is used by KubeArchive.
cc @ralphbean @hugares