Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Knative Event, KubeArchive dependency, as infra component #4764

Merged

Conversation

rh-hemartin
Copy link
Contributor

I'm adding Knative Eventing because its a dependency for KubeArchive. There was an ADR to install it for everyone use, but my intention here is that is used by KubeArchive.

cc @ralphbean @hugares

@rh-hemartin
Copy link
Contributor Author

I will submit corrections for the kube-lint problems.

@rh-hemartin rh-hemartin force-pushed the add-knative-eventing branch 2 times, most recently from 82f8706 to 4d9cf61 Compare October 21, 2024 15:03
@ralphbean
Copy link
Member

Quick feedback: you should add an OWNERS file in components/knative-eventing/ similar to the others in components/*/.

@ralphbean
Copy link
Member

I think you may be missing important bits in argo-cd-apps/overlays/*/delete-applications.yaml and possibly also argo-cd-apps/overlays/development/kustomization.yaml

@ralphbean ralphbean requested a review from hugares October 23, 2024 13:34
@ralphbean
Copy link
Member

/lgtm

@ralphbean
Copy link
Member

@rh-hemartin this looks good to me, but I'd like @hugares to ack it as well to minimize any surprises.

@hugares
Copy link
Contributor

hugares commented Oct 23, 2024

@rh-hemartin this looks good to me, but I'd like @hugares to ack it as well to minimize any surprises.

I have a packed morning, I will check this later today

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, rh-hemartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e81ca85 into redhat-appstudio:main Oct 23, 2024
6 checks passed
@hugares
Copy link
Contributor

hugares commented Oct 24, 2024

@rh-hemartin The knative application deployed but there a sync loop, some cluster role are out of sync, then sync, then out of sync and so on.

I did not have time to look into this, please have a look

@rh-hemartin rh-hemartin deleted the add-knative-eventing branch October 24, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants