Skip to content

Commit

Permalink
Removed as won't work as tekton will populate a String while we expec…
Browse files Browse the repository at this point in the history
…t an int. see: shipwright-io/build#1354

Signed-off-by: cmoulliard <[email protected]>
  • Loading branch information
cmoulliard committed Aug 9, 2023
1 parent 4ac0dd4 commit c00f644
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions k8s/shipwright/secured/clusterbuildstrategy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ spec:
image: $(params.CNB_BUILDER_IMAGE)
imagePullPolicy: Always
securityContext:
runAsUser: $(params.USER_ID)
runAsGroup: $(params.GROUP_ID)
runAsUser: 1001 # Won't work : $(params.USER_ID) -> https://github.com/shipwright-io/build/issues/1354
runAsGroup: 1000 # Won't work : $(params.GROUP_ID) -> https://github.com/shipwright-io/build/issues/1354
command: ["/cnb/lifecycle/builder"]
args:
- "-app=$(workspaces.source.path)/$(params.SOURCE_SUBPATH)"
Expand Down Expand Up @@ -234,6 +234,7 @@ spec:
requests:
cpu: 250m
memory: 65Mi

- name: export
image: $(params.CNB_LIFECYCLE_IMAGE)
imagePullPolicy: Always
Expand Down Expand Up @@ -261,6 +262,7 @@ spec:
- mountPath: /selfsigned-certificates
name: certificate-registry
readOnly: true

- name: results
image: docker.io/library/bash:5.1.4
args:
Expand Down
4 changes: 2 additions & 2 deletions k8s/shipwright/unsecured/clusterbuildstrategy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ spec:
image: $(params.CNB_BUILDER_IMAGE)
imagePullPolicy: Always
securityContext:
runAsUser: $(params.USER_ID)
runAsGroup: $(params.GROUP_ID)
runAsUser: 1001 # Won't work : $(params.USER_ID) -> https://github.com/shipwright-io/build/issues/1354
runAsGroup: 1000 # Won't work : $(params.GROUP_ID) -> https://github.com/shipwright-io/build/issues/1354
command: ["/cnb/lifecycle/builder"]
args:
- "-app=$(workspaces.source.path)/$(params.SOURCE_SUBPATH)"
Expand Down

0 comments on commit c00f644

Please sign in to comment.