Admin assistant updates #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jland-redhat
requested changes
Dec 6, 2024
| * @param event the startup event | ||
| */ | ||
| public void onStart(@Observes StartupEvent event) { | ||
| MongoDatabase database = mongoClient.getDatabase("composer"); |
There was a problem hiding this comment.
Could we add this to the liquibase instead of here just to make it consistent?
https://docs.liquibase.com/change-types/add-unique-constraint.html
jland-redhat
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of new endpoints:
GET admin/assistant/{id}
GET admin/assistant/llm/{id}
GET admin/assistant/retrieverConnection/{id}
DELETE admin/assistant/{id}
DELETE admin/assistant/llm/{id}
DELETE admin/assistant/retrieverConnection/{id}
and POST now does Updates if "id" is provided in the request.
Added two classes:
MISSING: MongoDB can be configured with object dependencies. I was reading about the setup but didn't make the changes. The current issue is that you can DELETE an Llm and the Assistant will just stay without the Llm which I believe is a bad state.