-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release notes links #843
Fix release notes links #843
Conversation
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-843/ @ 01/27/25 12:27:32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving /lgtm
890c5fc
to
e813b6b
Compare
modules/release-notes/ref-release-notes-deprecated-functionalities.adoc
Outdated
Show resolved
Hide resolved
release notes are generated using JIRA as the single source of truth. Please apply your changes in https://issues.redhat.com/browse/RHIDP-3621 then run this script: If you apply these changes and then we release a 1.4.2 security / bug fix update, your changes will be overwritten by the above script. So it's 100% better to use JIRA release note text fields for the contents of the release notes. |
Regenerated from JIRA release note text fields and pushed the changes into your PR. If that reverted your requested changes, please apply them in JIRA and I can re-run the Here's my changes (with whitespace / line ending changes ignored): |
6bc66e9
to
4a8f61e
Compare
Hi @nickboldt , I ran the script and this PR should be in sync with those from your end. |
That is a great suggestion, as well as wonderful questions you have raised, @linfraze . I trust that a summary of the content in the link, rather than linking the entire document, might suffice in this case. My question, however, is where to draw the line on what to highlight from the upstream document, especially if we want to avoid leaving the user searching for additional content from where they cannot access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RN status for https://issues.redhat.com/browse/RHIDP-4780 should be changed to exclude this item from the RN regeneration script at https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/blob/release-1.4/modules/release-notes/single-source-release-notes.py
7be7c2f
to
5611a2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice you removed https://issues.redhat.com//browse/RHIDP-3817 as it's now set as upstream only. 👍
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5458