-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm install script #27
Helm install script #27
Conversation
…ing a combination of commands get route or get ingress followed by grep to search for a line containing console or default and then awk to extract the desired field from that line, I went with more direct approach with -o=jsonpath option to extract the host value directly from the JSON output of the get route or get ingress command.
… available, and examples of usage all using the usage function, this helps keep docs information centralized reducing cognitive load.
The name of the script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off to a good start! I made some suggestions.
…sound like it stalls he Helm executable.
Included logic to validate the --cli parameter. Retained the automatic detection of CLI if --cli is not provided. Updated usage instructions to reflect the new --cli option.
…suring that the script exists early if the necessary components are not available. This prevents unnecessary execution of other parts of the script.
…to specify a custom release name or generate one automatically.
Apologies but I've just realized two things: a) this issue was only about helm CLI installs on OCP, and https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.1/html-single/administration_guide_for_red_hat_developer_hub/index#proc-rhdh-deploy-eks-using-helm_admin-rhdh and so perhaps we can make this script simpler and just handle the OCP install case. Keep It Super Simple, as they say. |
cc @rm3l for review, please |
…action for the user so they know where to get oc or helm to install it.
…de it if it does. And removing the md file because the instructions are present in the usage function of the script.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on Dev Sandbox and ClusterBot.
PR abandoned, because https://issues.redhat.com/browse/RHIDP-2706 was closed. |
Issue: RHIDP-2706 - script CLI helm installation for OCP
Continued from RHIDP-2614 re: redhat-developer/red-hat-developers-documentation-rhdh#287
Instead of giving people 20 steps to iterate though, AND having the same steps captured by QE when doing install validation tests, we should instead:
The script does the following:
The script is stored in https://github.com/redhat-developer/rhdh-chart/ using a similar documentation/script approach to
https://github.com/janus-idp/operator/tree/main/.rhdh/docs
https://github.com/janus-idp/operator/tree/main/.rhdh/scripts
I have also created a detailed document with more instructions as to how to use the script as an install.md file also within the scripts directory.
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.