-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script CLI helm installation for OCP #39
base: main
Are you sure you want to change the base?
script CLI helm installation for OCP #39
Conversation
Quality Gate passedIssues Measures |
|
||
usage() { | ||
echo " | ||
This script simplifies and automates the installation process of Helm charts on the OpenShift Container Platform (OCP) clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script simplifies and automates the installation process of Helm charts on the OpenShift Container Platform (OCP) clusters. | |
This script automates the installation of Helm charts on OpenShift Container Platform (OCP). |
usage() { | ||
echo " | ||
This script simplifies and automates the installation process of Helm charts on the OpenShift Container Platform (OCP) clusters. | ||
It ensures that the user is logged into a cluster and attempts to detect the cluster router base, updating the Helm chart configuration accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It ensures that the user is logged into a cluster and attempts to detect the cluster router base, updating the Helm chart configuration accordingly. | |
It ensures that the user is logged in, and detects the cluster router base to configure the Helm chart. |
|
||
Examples: | ||
$0 # Auto-detects router base and installs the Helm chart | ||
$0 --router-base example.com # Manually specifies the router base and installs the Helm chart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$0 --router-base example.com # Manually specifies the router base and installs the Helm chart | |
$0 --router-base apps.example.com # Manually specifies the router base and installs the Helm chart |
fi | ||
|
||
# Check if required files and directories exist | ||
HELM_CHART_DIR="$(dirname "$0")/../charts/backstage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using a local path reference to the charts folder will requires that this repo be cloned to be useable.
Is there a way to achieve the same thing from a single command, like https://github.com/rhdh-bot/openshift-helm-charts/blob/rhdh-1-rhel-9/installation/install.sh ? that would mitigate some of the docs team's concerns about usability
Issue: RHIDP-2706 - script CLI helm installation for OCP
FYI this script has gone through iterative improvements and has been approved #27 - more feedback is welcome on this PR.
Continued from RHIDP-2614 re: redhat-developer/red-hat-developers-documentation-rhdh#287
Instead of giving people 20 steps to iterate though, AND having the same steps captured by QE when doing install validation tests, we should instead:
The script does the following:
The script should be stored in https://github.com/redhat-developer/rhdh-chart/ using a similar documentation/script approach to
https://github.com/janus-idp/operator/tree/main/.rhdh/docs
https://github.com/janus-idp/operator/tree/main/.rhdh/scripts
I have also Tested on Dev Sandbox and ClusterBot LGTM
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.