fix: generated secret name should follow release name #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreydaley
force-pushed
the
2024-04-17-RHIDP-2034-fix-secret-name
branch
from
3f03766 to
02e578b
Compare
|
any concerns with running this on k8s vs. OSD (sandbox) vs. OCP vs. ROSA vs. clusterbot ...? if not then LGTM. |
The generated backend auth secret and the values.yaml file seem to be run under different contexts which will not allow the use of `common.names.fullname` to get the name of the current release of the chart. The secret will always grab the name of the redhat-developer-hub chart. So instead we should use the `.Release.Name` which will always be the release name for both.
coreydaley
force-pushed
the
2024-04-17-RHIDP-2034-fix-secret-name
branch
from
02e578b to
68ac643
Compare
|
coreydaley
changed the title
|
I ran it on ROSA, I create a clusterbot and try it also. |
nickboldt
approved these changes
Apr 17, 2024
|
@nickboldt |
|
will this change affect new helm chart releases for 1.0.z, 1.1.z, and 1.2.0? Or is there anything we need to do to cherrypick for previous releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated backend auth secret and the values.yaml file seem to be run under different contexts which will not allow the use of
common.names.fullnameto get the name of the current release of the chart. The secret will always grab the name of the redhat-developer-hub chart. So instead we should use the.Release.Namewhich will always be the release name for both.Ref: https://issues.redhat.com/browse/RHIDP-2034