forked from janus-idp/helm-backstage
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Jinja auto-escape is set to false #28
Merged
coreydaley
merged 5 commits into
redhat-developer:main
from
coreydaley:2024-06-21-set-autoescape-true
Jun 24, 2024
Merged
fix: Jinja auto-escape is set to false #28
coreydaley
merged 5 commits into
redhat-developer:main
from
coreydaley:2024-06-21-set-autoescape-true
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2.Template is called with no autoescape argument (autoescaping is disabled by default). This increases the risk of Cross-Site Scripting (XSS) attacks.
coreydaley
commented
Jun 21, 2024
nickboldt
reviewed
Jun 21, 2024
nickboldt
approved these changes
Jun 21, 2024
@rm3l @gazarenkov ptal |
rm3l
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I noticed that charts/backstage/README.md
had changed after running all the pre-commit hooks. But I guess that's a separate issue.
/approve
I have updated the README via the pre-commit hook and pushed the changes. |
coreydaley
added a commit
to coreydaley/redhat-developer-rhdh-chart
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jinja2.Template is called with no autoescape argument (autoescaping is disabled by default). This increases
the risk of Cross-Site Scripting (XSS) attacks.
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.