fix: Make the dynamic plugins root PVC storage class configurable [RHDHBUGS-156][RHIDP-5573] #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes.
|
rm3l
requested review from
gazarenkov and
Fortune-Ndlovu
and removed request for
nickboldt and
tumido
gazarenkov
reviewed
Jan 20, 2025
gazarenkov
approved these changes
Jan 20, 2025
kadel
approved these changes
Jan 20, 2025
rm3l
deleted the
RHDHBUGS-156--RHIDP-5573--make-storage-class-configurable
branch
|
/cherry-pick release-1.3 Backport needed for 1.3 (https://issues.redhat.com/browse/RHIDP-5835) and 1.4 (https://issues.redhat.com/browse/RHIDP-5836) |
|
@rm3l: #69 failed to apply on top of branch "release-1.3": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
rm3l
added a commit
to rm3l/rhdh-chart
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (redhat-developer#69) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
rm3l
added a commit
to rm3l/rhdh-chart
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (redhat-developer#69) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
rm3l
added a commit
to rm3l/rhdh-chart
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (redhat-developer#69) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
rm3l
added a commit
to rm3l/rhdh-chart
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (redhat-developer#69) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
rm3l
added a commit
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (#69) (#80) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
rm3l
added a commit
to rm3l/rhdh-chart
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (redhat-developer#69) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
Merged
4 tasks
rm3l
added a commit
that referenced
this pull request
Feb 3, 2025
…DHBUGS-156][RHIDP-5573] (#69) (#90) * Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes. * Bump the Chart version * Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters * Add test values file * Regenerate README
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR extracts the dynamic plugins root PVC spec in a new
dynamicPlugins.cache.volumeClaimSpecfield in the values file.This way, the whole PVC spec is configurable, including the storage class name, along with other things like the PVC size and access modes.
This should also help with https://issues.redhat.com/browse/RHIDP-5516 (make it possible to disable the dynamic plugin cache PVC and switch to an ephemeral volume).
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.