RHIDP-1703: Revert querying of OCP Cluster Ingress

[coreydaley]

Revert the automatic querying of the OCP Cluster Ingress for the domain to use for the clusterRouterBase as regular users do not have access to this resource, only cluster admins.

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
• JSON Schema template updated and re-generated the raw schema via pre-commit hook.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[rm3l]

Revert the automatic querying of the OCP Cluster Ingress for the domain to use for the clusterRouterBase as regular users do not have access to this resource, only cluster admins.

I guess the issue that the reverted commit was supposed to fix should be somehow reopened here or in JIRA as not fixed?
janus-idp#167?

[nickboldt]

Revert the automatic querying of the OCP Cluster Ingress for the domain to use for the clusterRouterBase as regular users do not have access to this resource, only cluster admins.

I guess the issue that the reverted commit was supposed to fix should be somehow reopened here or in JIRA as not fixed? janus-idp#167?

makes sense, yeah -- however janus-idp#167 is in an archived repo, so we need a new issue in https://github.com/redhat-developer/rhdh-chart/ ... but there are no issues for that repo because we use JIRA instead.

[coreydaley]

@rm3l From what I can see there is not a programmatical way to solve this issue due to limitations in Helm. The issue is really solved via the documentation that describes what information should be placed in the clusterRouterBase field. I was also thinking that maybe we could just have this code run if the user is a cluster-admin, but I don't see a way using helm to determine that as the install just fails on the lookup command, even if it is just used in an if block.

[nickboldt]

approved to make the GH spice flow, but I'm not an SME. recommend further scrutiny.

[coreydaley]

Two approvals, I am going to go ahead and merge this.

[rm3l]

@rm3l From what I can see there is not a programmatical way to solve this issue due to limitations in Helm. The issue is really solved via the documentation that describes what information should be placed in the clusterRouterBase field. I was also thinking that maybe we could just have this code run if the user is a cluster-admin, but I don't see a way using helm to determine that as the install just fails on the lookup command, even if it is just used in an if block.

No problem, just wanted to make sure that people who reported the original issue (janus-idp#167) were aware of this revert in case they expected the original issue to have been implemented (and were maybe depending on it), in which case this PR would have been a potential breaking change.
But after a closer look at janus-idp#167, it was requested in rhdhorchestrator/orchestrator-helm-chart#12. But it seems from their Chart.yaml that they are no longer using the RHDH Chart, but are now using the RHDH Operator instead.
So I guess we don't need to create a JIRA issue for janus-idp#167