fix(orchestrator): Add retrigger option to UI using v2 API #300
Conversation
Signed-off-by: Lior Soffer <[email protected]>
Signed-off-by: Lior Soffer <[email protected]>
Signed-off-by: Lior Soffer <[email protected]>
LiorSoffer
requested review from
batzionb,
mareklibra and
gciavarrini
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
| @@ -148,6 +149,7 @@ export class SonataFlowService { | |||
|
|
|||
| if (!response.ok) { | |||
| const json = await response.json(); | |||
| json.details = `failedNodeId:${json?.failedNodeId}`; | |||
There was a problem hiding this comment.
Please correct me, is that augmentation for the generic error handler to include that in the user-facing message?
If so, we can use it but please make sure we do not loose the details which might be potentially sent by the server.
There was a problem hiding this comment.
yes it is the purpose. do you think is needed to provide the user the failing node?
| setAnchorEl(event.currentTarget); | ||
| }; | ||
|
|
||
| const handleCloseMenue = () => { |
There was a problem hiding this comment.
| const handleCloseMenue = () => { | |
| const handleCloseMenu = () => { |
| anchorEl={anchorEl} | ||
| open={Boolean(anchorEl)} | ||
| onClose={handleCloseMenue} | ||
| getContentAnchorEl={null} |
There was a problem hiding this comment.
Is that property needed?
There was a problem hiding this comment.
getContentAnchorEl determines how the menu is positioned relative to the button
| } | ||
| }; | ||
|
|
||
| const [anchorEl, setAnchorEl] = React.useState<null | HTMLElement>(null); |
There was a problem hiding this comment.
Storing HTML elements in React state is gross. Can we use useRef instead?
Signed-off-by: Lior Soffer <[email protected]>
|
resolve FLPATH-1684
Screencast.from.2025-01-19.17-23-20.mp4