Add a containerized helmExport offering #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a containerized helmExport offering and corresponding `helmExport.sh` script for invoking a containerized image. A future PR will include automatically building the container image based on a nightly cadence. The README.md is updated to reflect the instructions to build/run the containerized offering. Signed-off-by: Ryan Goulding <[email protected]>
aneeshkp
reviewed
Jul 1, 2021
| RUN mkdir -p ${HELM_EXPORT_BIN} && \ | ||
| cp ${HELM_EXPORT_SRC_DIR}/${HELM_EXPORT_EXECUTABLE} ${HELM_EXPORT_BIN} | ||
|
|
||
| RUN ${PKGMGR} remove -y make tar wget && \ |
There was a problem hiding this comment.
could we use Multi-stage build here?
Example
FROM golang:1.14.3-alpine AS build
Copy the entire project and build it
This layer is rebuilt when a file changes in the project directory
COPY . /go/src/project/
RUN go build -o /bin/project
This results in a single layer image
FROM registry.access.redhat.com/ubi8/ubi-minimal:latest
COPY --from=build /bin/project /bin/project
ENTRYPOINT ["/bin/project"]
CMD ["--help"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a containerized helmExport offering and corresponding
helmExport.shscript for invoking a containerized image. A futurePR will include automatically building the container image based on
a nightly cadence.
The README.md is updated to reflect the instructions to build/run
the containerized offering.
Signed-off-by: Ryan Goulding [email protected]