support for 4.5 #96
support for 4.5 #96
Conversation
images_and_binaries.sh
Outdated
| if [ "$OPENSHIFT_RHCOS_MAJOR_REL" == "4.4" ]; then | ||
| BUILDS_JSON="$(curl -sS https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-$OPENSHIFT_RHCOS_MAJOR_REL/builds.json)" | ||
| if [ "$OPENSHIFT_RHCOS_MAJOR_REL" == "4.4" ] || [ "$OPENSHIFT_RHCOS_MAJOR_REL" == "4.5" ]; then | ||
| BUILDS_JSON="$(curl -sS https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.4/builds.json)" |
There was a problem hiding this comment.
We would need to differentiate here between 4.4 and 4.5 in this URL.
There was a problem hiding this comment.
+1, seems 4.5 rhcos url is available now, I will change it.
prep_bm_host.sh
Outdated
| @@ -161,7 +161,7 @@ printf "\nConfiguring baremetal interface (%s) and bridge (%s)...\n\n" "$BM_INTF | |||
|
|
|||
| sudo tee "/etc/sysconfig/network-scripts/ifcfg-$BM_BRIDGE" > /dev/null << EOF | |||
| TYPE=Bridge | |||
| NM_CONTROLLED=no | |||
| NM_CONTROLLED=yes | |||
There was a problem hiding this comment.
What is the reason for this change for the baremetal bridge/interface?
There was a problem hiding this comment.
This is not a 4.5 specific change, I used this PR for testing with centos 8 provision host, where if NM_CONTROLLED=no, baremetal bridge won't get static IP address assigned.
| if [[ -z $OPENSHIFT_RHCOS_MAJOR_REL || (! $OPENSHIFT_RHCOS_MAJOR_REL =~ (4.1|4.2|4.3|4.4|latest)) ]]; then | ||
| OPENSHIFT_RHCOS_MAJOR_REL="4.3" | ||
| if [[ -z $OPENSHIFT_RHCOS_MAJOR_REL || (! $OPENSHIFT_RHCOS_MAJOR_REL =~ (4.1|4.2|4.3|4.4|4.5|latest)) ]]; then | ||
| OPENSHIFT_RHCOS_MAJOR_REL="4.4" |
There was a problem hiding this comment.
I think we should leave this as 4.3 for now, because 4.4 requires 3 masters to successfully deploy a cluster. My concern is that people are using this to deploy 1-master clusters without explicitly specifying 4.3 or earlier. So in those cases, if we set the default to 4.4, suddenly their deployments would fail and they might not understand why.
No description provided.